Add Puppet proxy (CA) bulk actions by nadjaheitmann · Pull Request #429 · theforeman/foreman_puppet

nadjaheitmann · 2025-09-24T10:52:47Z

@adamruzicka @jeremylenz I have created a draft for the Puppet Proxy update bulk action. It is not more than a draft and I know there is a bunch of things missing (e.g. clearing proxy, CA proxy, tests, ...). I basically took code from Foreman and Katello and mixed it into this. Do you mind checking whether the general approach is the direction we want to go. UI wise, I think this is straight forward, but I was not sure whether

extending the BulkHostManager
adding a new API endpoint to the HostsBulkActionsController
adding the API endpoint itself to the Foreman rather than the foreman_puppet namespace

is the way to go.

I appreciate your opinions.

adamruzicka

Left some notes inline, can't speak much to the frontend

adamruzicka · 2025-09-24T12:01:14Z

+
+        api :PUT, "/hosts/bulk/change_puppet_proxy", N_("Change Puppet Proxy")
+        param_group :bulk_host_ids
+        param :proxy_id, :number, :required => true, :desc => N_("ID of the Puppet proxy to reassign the hosts to")


This being required means it can be used to reassign the host to a different proxy, but this cannot be used to unassign it, correct?

Correct. I have not yet implemented the unassign method, so the implementation details about that one are still open.

adamruzicka · 2025-09-24T12:02:31Z

+              host.puppet_ca_proxy = proxy
+            else
+              host.puppet_proxy = proxy
+            end
+            host.save(:validate => false)


Do we need callbacks to be run or could we take a shortcut and assign the proxy with a single update query?

Not sure, if we need callbacks to be honest. The original action does run some validations about validating the proxy I think: https://github.com/theforeman/foreman_puppet/blob/master/app/controllers/concerns/foreman_puppet/extensions/hosts_controller_extensions.rb#L143

Can the update command also take the validate => false parameter?

nadjaheitmann

Thanks @adamruzicka !

nadjaheitmann · 2025-09-24T12:21:18Z

+
+        api :PUT, "/hosts/bulk/change_puppet_proxy", N_("Change Puppet Proxy")
+        param_group :bulk_host_ids
+        param :proxy_id, :number, :required => true, :desc => N_("ID of the Puppet proxy to reassign the hosts to")


Correct. I have not yet implemented the unassign method, so the implementation details about that one are still open.

nadjaheitmann · 2025-09-24T12:28:00Z

+              host.puppet_ca_proxy = proxy
+            else
+              host.puppet_proxy = proxy
+            end
+            host.save(:validate => false)


Not sure, if we need callbacks to be honest. The original action does run some validations about validating the proxy I think: https://github.com/theforeman/foreman_puppet/blob/master/app/controllers/concerns/foreman_puppet/extensions/hosts_controller_extensions.rb#L143

Can the update command also take the validate => false parameter?

jeremylenz

Did a quick read of the frontend code, a couple comments below

nadjaheitmann · 2026-03-09T16:13:53Z

This PR uses theforeman/foreman@40938e4 , so it will only work with Foreman 3.19+

adamruzicka

I currently don't have an environment to test this, but code wise it looks good.

nadjaheitmann · 2026-05-06T09:48:49Z

environ

Thanks @adamruzicka . I accidentally requested another review from you, feel free to ignore that.

nadjaheitmann · 2026-05-11T06:48:11Z

I currently don't have an environment to test this, but code wise it looks good.

I had a test session with @sbernhard and @Manisha15 . We tested the PR, verified that the permissions work and added a UI warning in case there is no smart proxy with Puppet(CA) feature available:

Assisted-by: OpenAI Codex <codex@openai.com>

nadjaheitmann · 2026-05-11T11:30:42Z

@adamruzicka We had another internal review and testing round. I would go ahead and merge it if you don't mind. If there are bugs left, we can fix them in a follow-up.

Manisha15

LGTM

Assisted-by: OpenAI Codex <codex@openai.com>

pr-processor Bot added the Not yet reviewed label Sep 24, 2025

adamruzicka reviewed Sep 24, 2025

View reviewed changes

pr-processor Bot removed the Not yet reviewed label Sep 24, 2025

nadjaheitmann force-pushed the new_all_hosts_page_puppet_proxy_actions branch from e2b1c7f to c7dd83c Compare September 24, 2025 12:15

nadjaheitmann commented Sep 24, 2025

View reviewed changes

nadjaheitmann force-pushed the new_all_hosts_page_puppet_proxy_actions branch 2 times, most recently from ac62ab7 to e980546 Compare September 24, 2025 12:48

nadjaheitmann force-pushed the new_all_hosts_page_puppet_proxy_actions branch 3 times, most recently from 11c8919 to 4512e86 Compare October 13, 2025 07:52

nadjaheitmann force-pushed the new_all_hosts_page_puppet_proxy_actions branch from 4512e86 to 2eb2f1a Compare January 21, 2026 17:09

nadjaheitmann force-pushed the new_all_hosts_page_puppet_proxy_actions branch 3 times, most recently from 4bb7ef6 to 0faf7d6 Compare February 10, 2026 10:44

nadjaheitmann force-pushed the new_all_hosts_page_puppet_proxy_actions branch 3 times, most recently from 75e0f00 to 7d7c810 Compare February 18, 2026 13:40

nadjaheitmann force-pushed the new_all_hosts_page_puppet_proxy_actions branch from d68caaf to 0caaa68 Compare March 2, 2026 09:21

jeremylenz reviewed Mar 2, 2026

View reviewed changes

Comment thread webpack/src/Extends/Hosts/ActionsBar/index.js Outdated

Comment thread webpack/src/Extends/Hosts/ActionsBar/index.js Outdated

Comment thread webpack/src/Extends/Hosts/ActionsBar/index.js Outdated

Comment thread webpack/src/Extends/Hosts/ActionsBar/index.js Outdated

nadjaheitmann mentioned this pull request Mar 2, 2026

Fixes #39047 - replace useForemanModal in BulkActions Katello/katello#11626

Merged

nadjaheitmann force-pushed the new_all_hosts_page_puppet_proxy_actions branch 9 times, most recently from 98fdd79 to dfb9239 Compare April 10, 2026 12:35

nadjaheitmann force-pushed the new_all_hosts_page_puppet_proxy_actions branch 2 times, most recently from 1268415 to 7db72d3 Compare April 27, 2026 12:06

nadjaheitmann force-pushed the new_all_hosts_page_puppet_proxy_actions branch 2 times, most recently from 0c74440 to 44484fc Compare May 6, 2026 08:38

pr-processor Bot removed the Needs re-review label May 6, 2026

adamruzicka reviewed May 6, 2026

View reviewed changes

Comment thread app/controllers/foreman_puppet/api/v2/hosts_bulk_actions_controller.rb Outdated

Comment thread config/api_routes.rb

nadjaheitmann force-pushed the new_all_hosts_page_puppet_proxy_actions branch from 44484fc to f3e13d0 Compare May 6, 2026 09:25

nadjaheitmann requested a review from adamruzicka May 6, 2026 09:37

nadjaheitmann changed the title ~~Draft: Add Puppet proxy (CA) bulk actions~~ Add Puppet proxy (CA) bulk actions May 7, 2026

nadjaheitmann force-pushed the new_all_hosts_page_puppet_proxy_actions branch 2 times, most recently from 8d0052d to 015a91c Compare May 11, 2026 07:11

sbernhard reviewed May 11, 2026

View reviewed changes

Comment thread app/services/concerns/foreman_puppet/extensions/bulk_hosts_manager.rb Outdated

sbernhard reviewed May 11, 2026

View reviewed changes

Comment thread webpack/src/Extends/Hosts/ActionsBar/index.js

sbernhard reviewed May 11, 2026

View reviewed changes

Comment thread webpack/src/Extends/Hosts/ActionsBar/index.js

nadjaheitmann force-pushed the new_all_hosts_page_puppet_proxy_actions branch 5 times, most recently from b143112 to dc8e586 Compare May 11, 2026 08:31

Add Puppet proxy (CA) bulk actions

70afff5

Assisted-by: OpenAI Codex <codex@openai.com>

nadjaheitmann force-pushed the new_all_hosts_page_puppet_proxy_actions branch from dc8e586 to 70afff5 Compare May 11, 2026 08:52

sbernhard reviewed May 11, 2026

View reviewed changes

Comment thread app/services/concerns/foreman_puppet/extensions/bulk_hosts_manager.rb

sbernhard approved these changes May 11, 2026

View reviewed changes

Manisha15 approved these changes May 13, 2026

View reviewed changes

Manisha15 merged commit f754e11 into master May 13, 2026
12 checks passed

nadjaheitmann deleted the new_all_hosts_page_puppet_proxy_actions branch May 13, 2026 08:27

me-minus pushed a commit to me-minus/foreman_puppet that referenced this pull request Jun 20, 2026

Add Puppet proxy (CA) bulk actions (theforeman#429)

3eeb7c0

Assisted-by: OpenAI Codex <codex@openai.com>

Uh oh!

Conversation

nadjaheitmann commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adamruzicka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

adamruzicka Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

nadjaheitmann Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

adamruzicka Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

nadjaheitmann Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nadjaheitmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nadjaheitmann Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nadjaheitmann Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jeremylenz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nadjaheitmann commented Mar 9, 2026

Uh oh!

adamruzicka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nadjaheitmann commented May 6, 2026

Uh oh!

nadjaheitmann commented May 11, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nadjaheitmann commented May 11, 2026

Uh oh!

Manisha15 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nadjaheitmann commented Sep 24, 2025 •

edited

Loading